Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the temperature parsing in virtium nvme disks #475

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix the temperature parsing in virtium nvme disks #475

merged 1 commit into from
Jun 17, 2024

Conversation

vivekrnv
Copy link
Contributor

@vivekrnv vivekrnv commented Jun 10, 2024 •
edited
Loading

Description

Fix sonic-net/sonic-buildimage#19020

If the vendor utility couldn't infer the temperature, display the temperature inferred from smartctl utility

Motivation and Context

How Has This Been Tested?

Temperature can be read from smartctl utility

root@sonic:/home/admin# smartctl /dev/nvme0n1 -a 
smartctl 7.4 2023-08-01 r5530 [x86_64-linux-6.1.0-11-2-amd64] (local build)
Copyright (C) 2002-23, Bruce Allen, Christian Franke, www.smartmontools.org

=== START OF INFORMATION SECTION ===
Model Number:                       Virtium VTPM24CEXI080-BM110006
SMART/Health Information (NVMe Log 0x02)
Temperature:                        39 Celsius

Before this change
root@sonic:/home/admin# show platform ssdhealth
Device Model : Virtium VTPM24CEXI080-BM110006
Health       : 100.0%
Temperature  : N/A

After this change
root@sonic:/home/admin# show platform ssdhealth
Device Model : Virtium VTPM24CEXI080-BM110006
Health       : 100.0%
Temperature  : 39.0C

Additional Information (Optional)

@vivekrnv
Fix the temperature parsing in nvme disks
5cee49d 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv vivekrnv requested review from keboliu and prgeor June 10, 2024 15:18
@assrinivasan assrinivasan self-requested a review June 10, 2024 18:44
@prgeor prgeor merged commit 51c6207 into sonic-net:master Jun 17, 2024
5 checks passed
@vivekrnv vivekrnv deleted the fix_ssdhealth_na branch June 17, 2024 18:30
@prgeor
Copy link
Collaborator

prgeor commented Jun 24, 2024

@bingwang-ms can you cherry pick to 202405

mssonicbld pushed a commit to mssonicbld/sonic-platform-common that referenced this pull request Sep 11, 2024
@vivekrnv @mssonicbld
Fix the temperature parsing in nvme disks (sonic-net#475)
c4faa7d 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@mssonicbld mssonicbld mentioned this pull request Sep 11, 2024
Merged
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #498

mssonicbld pushed a commit that referenced this pull request Sep 11, 2024
@vivekrnv @mssonicbld
Fix the temperature parsing in nvme disks (#475)
d494347 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assrinivasan assrinivasan assrinivasan approved these changes

@prgeor prgeor prgeor approved these changes

@keboliu keboliu Awaiting requested review from keboliu

Assignees
No one assigned
Labels
Approved for 202405 Branch Included in 202405 Branch Request for 202405 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ssdutil] [Vitrium] Can't read ssd temperature on Vitrium nvme disks
5 participants
@vivekrnv @prgeor @mssonicbld @assrinivasan @bingwang-ms